News


User avatar
MysticalOS

DBM 7.3.19 WIP

Postby MysticalOS » Wed Jan 24, 2018 5:02 am

Bug Fixes

Nighthold:
  • Fixed lua error on Guldan

User avatar
MysticalOS

DBM 7.3.18 Released

Postby MysticalOS » Fri Jan 12, 2018 7:24 am

New Features:

Antorus:
  • Added option to control tank swap behavior for coven, by default it’s in 2/3 hybrid mode based on mythic or not.
  • Added special warning option for boss activation/return on Coven (on by default for tanks). If option is enabled the non special warning activation warning will be automatically suppressed

Changes

Core:
  • More changes to timer object to further reduce calls to spell,journal,achievement apis by caching spell/dungeon/achievement names in the timer object on first call.
  • Updated discord URL
  • Made icon to string and icon to texture globally available to DBM, and used it to apply more efficiently code in HUD slash object
  • Improved code for special warning flash objects.
  • Improved code for AI timer object

Antorus:
  • Interrupt warning on Mythic Coven will no longer apply target/focus filter. It'll always show for everyone who has an interrupt regardless of global filter setting.
  • Mines warning on High command will no longer use voice pack "watch your step" warning. It was a bit of an overkill sound wise. It'll default to soft night elf bell once more
  • Taunt warning for stacks on aggramar will no longer show if less than 4 seconds remains on combo timer.

5 Man Dungeons:
  • Re-enabled Dresaron's down draft timer on request. It was disabled though cause it was just not very accurate (30-48 second variation, possibly even larger). People still want the timer though.

Bug Fixes:

Core:
  • Fixed bug with AI timer object where valid lowest time seen timers could get overwritten on phase changes in AI timer object
  • Fixed a bug where AI timers could be created for first casts of a stage do to incomplete variables not wiped out on a boss wipe and then those variables used on next pull incorrectly.

Antorus:
  • Fixed cosmic glare timer not showing for any but first cast on Mythic Coven
  • Fixed aggramar in LFR to be 4 flame rends, since blizzard replaces the two foebreakers on that difficulty.

Tomb of Sargeras
  • Fixed infoframe not correctly hiding or switching back to debuff frame when shield broken on maiden

5 Man Dungeons
  • Fixed lua error with Nightbane Infoframe

Previous Release:
viewtopic.php?f=3&t=380#p1097

User avatar
MysticalOS

DBM 7.3.17 Released

Postby MysticalOS » Fri Jan 05, 2018 5:21 am

New Features

Core:
  • *Improve timer callbacks for improved weak auras

Antorus
  • Added countdown options to dog breaths
  • Finally added death fog GTFO to Argus
  • Finally added storm and blades GTFO's to Coven

Bug Fixes:

Core:
  • Fixed a bug where a timer might start in mods that use :AddTime function, when timers are disabled globally.
  • Fixed a bug where :AddTime object for timers didn't show timers if they had expired. If a timer is complete when AddTime runs, it starts new timer with addtime value now.
  • Fixed lua error that could occur in Mythic+ dungeons
  • Fixed bug where DBM showed speed kill timers on all keystone difficulty regardless of whether or not it was highest. DBM only stores fastest kill for highest keystone level achieved for that encounter, so if we've killed that boss on a 15, don't show timer on a 13 for our best 15 kill. It'll now only show if keystone level matches best keystone level.
  • Removed clickable link on out of date/new update notification. It hasn't worked since removing hyperlink hooks.
  • Fixed Machinations cast timer not canceling when all adds are dead on Coven.

Antorus:
  • Fixed a bug where if you wiped to Kingaroth at same time as he enters shield phase, timers could get started and not canceled on that wipe do to timers starting after wipe event fired.
  • Fixed bug that could cause lua errors for some users on Argus the Unmaker with certain icon options.

Changes:

Antorus
  • Changed yells for sea and sky on Argus to use stat yells like other mods/weak auras do. This is something I wasn't doing intentionally do to DBMs lack of localizers for over 7 languages, but i received increase push about this, so I made change.
  • Audio countdown for tank debuff on portal keeper now only counts from 3, down from 4. It is also now off by default. Overall, intended to reduce overall spammy feel of countdowns, especially in her room which has high reverb. This particular ability isn't an active mitigate it or die one and has high variation so it was best candidate for tone down.
  • Argus stage 3 will now trigger off an earlier event now that I've vetted it enough as a replacement for the later trigger. This will cancel/cleanup timers better.
  • Changed interrupt warnings for Mythic touch of cosmos spell on Coven to now be a 3 person interrupt rotation complete with notes support for assigning players by name to each of 3 casts.
  • Changed Cosmic Glare from a "move away" warning to a "target you" warning since the more accepted strat is to sit still [...]

User avatar
MysticalOS

DBM and Patch ??? (UPDATED)

Postby MysticalOS » Thu Jan 04, 2018 6:52 am

UPDATE: They canceled deployment of change for 7.3.5 and pushing it to a later patch. Leaving original article because the whole thing still holds true. I also update parts of article with newest info, so if parts of it read funny I might have messed up in doing so.

In patch 7.3.5 ??? they are changing way spell names are returned by API. Instead of returning them in same frame they are requested in, they return spell info without spell name in first frame, and queue spell name request to be returned in a later frame via SPELL_NAME_UPDATE. This causes significant breakage to mods without tons of code changes to work around it.

The reasoning for this change as explained to me is to improve client performance and reduce hitching caused by loading spell info in certain places such as achievement frame. Overall it should be a net gain in performance for base UI and even addons that call GetSpellInfo repeatedly. It allows blizzard to return the spell info right away and spell name in next frame to reduce hitching in client caused by the old spell API.

Here is where things get iffy. This change did not consider several cases for addon authors where such a system simply doesn't work well. One major example is LoadAddon. In many cases an addon author only ever requests a spellName for something once, OnLoad. Often times in these cases there is no onevent or onupdate handler to fix spell name after the fact. The mod loads, pulls spell info and calls it a day. This is no longer possible in 7.3.5 ??? what so ever. This requires addon authors to literally write functions to fix things after loading. Fortunately blizzard acknowledged this would be an issue and is one of reasons they canceled deployment of feature in 7.3.5 until they can give us a solution to deal with this.

Addon authors gave blizzard a lot pushback because the coding we would have had to do to fix this is not always simple and can border on stupid and may cost users the performance blizzard saved them and then some. Basically, one step forward two steps back with this change. Addon authors see why an async system is beneficial, but we simply wanted a solution to be used that isn't async for niche cases where it works in all addon type cases that makes sense and isn't ugly or performance hit to users or horrible to write hack.

On DBM for example, I've already corrected Announce and timer objects to work just fine with async spell names in an efficient manor that is 7.3.5 ??? friendly. These are fu [...]

User avatar
MysticalOS

DBM 7.3.16 Released

Postby MysticalOS » Sat Dec 30, 2017 2:12 am

New Features

Antorus:
  • Re-added bomb timer to kingaroth I forgot to re-add ages ago when I discovered how the bosses timers truly worked.

Bug Fixes:

Antorus:
  • Fixed bug where bomb warning fired for bombs detonating on kingaroth. Should only fire for them spawning
  • Fixed a bug where infoframe didn't close if aggramar phased mid combo
  • Fixed bug where icon sizes on infoframe were too large on aggramar
  • Fixed bug on imonar where info frame for empowered pulse didn't show icons on players right away do to frame updating before icons went out (and frame only updates on debuff apply for efficiency, so icons wouldn't display until next debuffs/update. Now, frame update is also updated when RAID_TARGET_UPDATE fires to ensure it grabs any icon change to targets shown on frame.

Broken Isles:
  • Calamir ice comet warning now uses correct spell icon
  • Calamir age warning no longer spits an invalid target name

Changes:

Core:
  • A bunch of changes added across core and mods to handle GetSpellInfo() changes in 7.3.5 a future patch. For more information, visit: viewtopic.php?f=3&t=379#p1096
  • *Special warning object now has built in voice pack handling instead of using separate object/option. This significantly eases boss mod creation for myself going forward. In addition, it'll also reduce config sizes and mod load times as well since a ton of redundancy was removed. It also makes it finally possible to enable special warning sound filters on custom localized warnings, which up until now made adding voice pack sounds to custom warnings, more difficult.
  • Thanks to above refactor, test mode will now utilize voice pack support if installed/enabled.
  • Regular warning object now also has built in voice pack handling, which didn't support voice packs or voice pack filters at all before. Now it does. This enables adding of voice alerts and suppressing of regular sounds for general announces. All without needing a separate voice object, so more custom voice objects were pruned.
    Changed Pod Assault warning on high command to use stacks instead of blizzards RAID_BOSS_WHISPER. although the whisper is exact time you should hop out on non mythic, on mythic it sometimes gets you killed if bats are still assaulting pod, then the reaction window for hopping out is very tiny and you can still die. So now the warning will trigger off stacks to try an and be slightly sooner to compensate for this. In addition, there are now pre warnings for 10, 15 stacks as well.

Antorus
  • Tidied up timer options i [...]