Register Search FAQ Memberlist Usergroups Log in  
Reply to topic patches for DBM-ChamberOfAspects
patches for DBM-ChamberOfAspects
jyuny1


Joined: 02 Apr 2009
Posts: 2
Reply with quote
hi guys,
I saw a new DBM plugin called DBM-Sarth-ShadowFissureWarn last night

ShionYu(not me) trys to merge the code of DBM-Sarth-ShadowFissureWarn into DBM-ChamberOfAspects

here is his patches(localization only for zhTW client)
http://opensvn.csie.org/kevinblue/wow/DBM-ChamberOfAspects/Shadron.lua.patch
http://opensvn.csie.org/kevinblue/wow/DBM-ChamberOfAspects/Tenebron.lua.patch
http://opensvn.csie.org/kevinblue/wow/DBM-ChamberOfAspects/Vesperon.lua.patch
http://opensvn.csie.org/kevinblue/wow/DBM-ChamberOfAspects/localization.tw.lua.patch
the new DBM-ChamberOfAspects seems works for us at zhTW client Smile

you can view the whole sources he modfied at
http://opensvn.csie.org/kevinblue/wow/DBM-ChamberOfAspects/

btw, is there any way DBM can use raid warning when Shadow Fissure show up?
View user's profileFind all posts by jyuny1Send private message
Morigahn


Joined: 02 Apr 2009
Posts: 4
Reply with quote
Heya, I'm the author of DBM-Sarth-ShadowFissureWarn. It's great to see interest in it!

Please feel free to clean up my code and make it better if you want when merging into DBM-ChamberOfAspects. I just threw it together as fast as I could to get something working so it's probably not the cleanest way to do things. In fact I just noticed some bugs. In Shadron.lua it should be self:SendSync("Shadron_ShadowFissureAlarm"), and in Vesperon.lua it should be self:SendSync("Vesperon_ShadowFissureAlarm"). Both are currently set at self:SendSync("Tenebron_ShadowFissureAlarm"). Damn copy-paste. =)

Anyways I'm happy to let DBM-Sarth-ShadowFissureWarn die if you want to take over.
View user's profileFind all posts by MorigahnSend private message
jyuny1


Joined: 02 Apr 2009
Posts: 2
Reply with quote
great!
thx for the information =)

hope DBM dev team accept this patch!
View user's profileFind all posts by jyuny1Send private message
yoshimo


Joined: 10 May 2008
Posts: 112
Reply with quote
I tried this on our 3drakes firstkill and i had a few errors in my swatter-log.

Code:
Date: 2009-04-05 20:36:08
ID: -28
Error occured in: Global
Count: 4
Message: ..\AddOns\DBM-Core\DBT.lua line 777:
   DBT_Bar_1:SetPoint(): trying to anchor to itself
Debug:
   [C]: ?
   [C]: SetPoint()
   DBM-Core\DBT.lua:777: SetPosition()
   DBM-Core\DBT.lua:342: CreateBar()
   DBM-Core\DBM-Core.lua:2047: Start()
   DBM-ChamberOfAspects\Sartharion.lua:102: func()
   DBM-Core\DBM-Core.lua:400:
      DBM-Core\DBM-Core.lua:384


Code:
Date: 2009-04-05 20:37:43
ID: -27
Error occured in: Global
Count: 8
Message: [string "DBT_Bar_5:OnUpdate"] line 1:
   attempt to index field 'obj' (a nil value)
Debug:
   [C]: ?
   [string "*:OnUpdate"]:1:
      [string "*:OnUpdate"]:1
AddOns:
View user's profileFind all posts by yoshimoSend private message
Morigahn


Joined: 02 Apr 2009
Posts: 4
Reply with quote
yoshimo wrote:
I tried this on our 3drakes firstkill and i had a few errors in my swatter-log.

.....


The error message that includes stack info says the error came from DBM-ChamberOfAspects\Sartharion.lua, but according to the links provided by jyuny1 at the start of this thread Sartharion.lua wasn't even patched, so I don't think those errors came from this. But since I had nothing to do with the DBM-ChamberOfAspects patch I really don't know for sure, sorry.
View user's profileFind all posts by MorigahnSend private message
yoshimo


Joined: 10 May 2008
Posts: 112
Reply with quote
i didnt use the patch but the module i found on wowinterface. so i thought i post here , because i dont know if it is a dbm buf, the module or maybe even the patch, which i didnt try yet.
View user's profileFind all posts by yoshimoSend private message
patches for DBM-ChamberOfAspects
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
All times are GMT + 1 Hour  
Page 1 of 1  

  
  
 Reply to topic  
Powered by phpBB © phpBB Group
Design by phpBBStyles.com | Styles Database.
Content © DeadlyBossMods.com
In association with Amazon